Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Update to bazel 5.1.0 #20516

Merged
merged 1 commit into from
Mar 29, 2022
Merged

build: Update to bazel 5.1.0 #20516

merged 1 commit into from
Mar 29, 2022

Conversation

keith
Copy link
Member

@keith keith commented Mar 24, 2022

@keith
build: Update to bazel 5.1.0
23a907a 
https://blog.bazel.build/2022/03/24/bazel-5.1.html

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #20516 was opened by keith.

see: more, trace.

@keith
Copy link
Member Author

keith commented Mar 25, 2022

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #20516 (comment) was created by @keith.

see: more, trace.

phlax
phlax approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phlax
Copy link
Member

phlax commented Mar 25, 2022

@keith is this ready to merge ?

cc @moderation

@moderation
Copy link
Contributor

moderation commented Mar 25, 2022 •
edited
Loading

lgtm 👍

Wondering if we can leverage the new C++ features

  • Added an experimental version of cc_shared_library. (#14773)
  • --experimental_cc_implementation_deps now propagates into exec configs. (#14753)

@keith keith marked this pull request as ready for review March 29, 2022 21:28
@keith
Copy link
Member Author

keith commented Mar 29, 2022

Yea this should be fine, happy to see there weren't any unexpected issues from CI. Yea I think at some point it's probably worth checking out implementation deps, I imagine there could be some improvements from that, but it would require some targeted changes I think

@keith keith merged commit fd92486 into envoyproxy:main Mar 29, 2022
@keith keith deleted the ks/build-update-to-bazel-5.1.0 branch March 29, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlax phlax phlax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keith @phlax @moderation